New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(types): add unbound property in parser options #5419
feat(types): add unbound property in parser options #5419
Conversation
Thanks for the PR, @juank1809! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #5419 +/- ##
==========================================
+ Coverage 91.67% 91.74% +0.07%
==========================================
Files 363 366 +3
Lines 12227 12344 +117
Branches 3549 3601 +52
==========================================
+ Hits 11209 11325 +116
Misses 668 668
- Partials 350 351 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
packages/types/src/parser-options.ts
Outdated
@@ -58,6 +78,7 @@ interface ParserOptions { | |||
tsconfigRootDir?: string; | |||
warnOnUnsupportedTypeScriptVersion?: boolean; | |||
moduleResolver?: string; | |||
[additionalProperties: string]: ParserOptionsValue | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You needn't add a specific type for the index signature because typescript will strictly type the known keys even with an unbounded index signature
[additionalProperties: string]: ParserOptionsValue | undefined; | |
[additionalProperties: string]: unknown; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this!
PR Checklist
Overview
Added a new mapped indexer to our parser options interface, this allows users to add any additional properties they want
Considerations
Maybe these other options that I discarded could fit better: